Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure data_volume isn't surrounded by quotes #21473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure data_volume isn't surrounded by quotes #21473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion make/prepare
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ else
fi
fi

data_path=$(grep '^[^#]*data_volume:' $input_dir/harbor.yml | awk '{print $NF}')
data_path=$(grep '^[^#]*data_volume:' $input_dir/harbor.yml | awk '{print $NF}' | sed 's/"//g')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is to remove the quote when there is a quote, sometimes the path may contain space, to remove quote will cause problem?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention is to remove the quote when there is a quote, sometimes the path may contain space, to remove quote will cause problem?

In my opinion, its already impossible to use a path with spaces due to: | awk '{print $NF}'.

Here is a test:

# grep data_volume harbor.yml
data_volume: "/srv/harbor/data directory with space"

# grep '^[^#]*data_volume:' harbor.yml | awk '{print $NF}'
space"

There is no change to expect about this.


# If previous secretkeys exist, move it to new location
previous_secretkey_path=/data/secretkey
Expand Down