Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with user create/delete/update event #21651

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.23%. Comparing base (c8c11b4) to head (0f19cee).
Report is 391 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21651      +/-   ##
==========================================
+ Coverage   45.36%   46.23%   +0.86%     
==========================================
  Files         244      249       +5     
  Lines       13333    14047     +714     
  Branches     2719     2897     +178     
==========================================
+ Hits         6049     6495     +446     
- Misses       6983     7207     +224     
- Partials      301      345      +44     
Flag Coverage Δ
unittests 46.23% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 493 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 25feb19_fix_issue_user_event branch 2 times, most recently from 5807142 to a50e161 Compare February 20, 2025 02:17
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 25feb19_fix_issue_user_event branch 2 times, most recently from 4f29432 to 57549f7 Compare February 20, 2025 07:55
@stonezdj stonezdj force-pushed the 25feb19_fix_issue_user_event branch from 57549f7 to 9440bd5 Compare February 21, 2025 02:46
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants