Edit the Resource Request guide #52393
Open
+150
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #33417 Focus the guide more on its stated topic by moving tangentially related reference information at the end of the guide to more appropriate pages. - Replace the `search_as_roles` section with a link. Much of the "Next steps" section is a long list of examples of Teleport roles that an admin could assign to `search_as_roles`. This is unnecessary, since a user familiar with a Teleport role won't need this information to understand `search_as_roles`. It is not the job of the Resource Requests guide to teach users about Teleport roles. - Condense the "Next steps" guidance. There are "Next steps" sections. Make them one. Also turn the section re: Access Request plugins into a bullet. - Move instructions for searching for and requesting Kubernetes resources into the tsh guide. These instructions are end users, so move them to the appropriate guide to make them more discoverable.
github-actions
bot
requested review from
mmcallister,
nklaassen,
r0mant,
ravicious,
xinding33 and
zmb3
github-actions
bot
added
documentation
no-changelog
|
Amplify deployment status
|
zmb3
reviewed
Feb 21, 2025
| @@ -1126,6 +1127,139 @@ $ tsh ssh node1.leaf1 | |||
| $ ssh node1.leaf1 | |||
| ``` | |||
|
|
|||
| ## Request access to resources | |||
There was a problem hiding this comment.
This feels more like it belongs in an "access requests" section of the docs, not in a tsh section of the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33417
Focus the guide more on its stated topic by moving tangentially related reference information at the end of the guide to more appropriate pages.
search_as_rolessection with a link. Much of the "Next steps" section is a long list of examples of Teleport roles that an admin could assign tosearch_as_roles. This is unnecessary, since a user familiar with a Teleport role won't need this information to understandsearch_as_roles. It is not the job of the Resource Requests guide to teach users about Teleport roles.