Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two-dimensional and dropdown-only docs Tabs #52395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Feb 21, 2025

Closes gravitational/docs-website#70

Tabs components that use a dropdown menu do not render on the Docusaurus site. Since there are not many of these in the docs content, it makes sense to change them to standard Tabs components instead of porting the legacy Tabs behavior to the new Docusaurus site.

  • Change long picker partials to use a standard Tabs component instead of a dropdown menu. While this is not ideal, it standardizes the Tabs component in the docs to only use attributes that the docs engine can process. All TabItems render as expected.
  • Remove an unused partial that uses two-dimensional Tabs (docs/pages/includes/install-linux-self-hosted.mdx).
  • In some guides, collapse two-dimensional Tabs components to only require one dimension.
  • In install-linux-enterprise.mdx, use the one-line installation script to simplify the instructions and avoid using Tabs entirely.

Closes gravitational/docs-website#70

`Tabs` components that use a dropdown menu do not render on the
Docusaurus site. Since there are not many of these in the docs content,
it makes sense to change them to standard `Tabs` components instead of
porting the legacy `Tabs` behavior to the new Docusaurus site.

- Change long picker partials to use a standard `Tabs` component instead
  of a dropdown menu. While this is not ideal, it standardizes the
  `Tabs` component in the docs to only use attributes that the docs
  engine can process. All `TabItems` render as expected.
- Remove an unused partial that uses two-dimensional `Tabs`
  (`docs/pages/includes/install-linux-self-hosted.mdx`).
- In some guides, collapse two-dimensional `Tabs` components to only
  require one dimension.
- In `install-linux-enterprise.mdx`, use the one-line installation
  script to simplify the instructions and avoid using `Tabs` entirely.
Copy link

github-actions bot commented Feb 21, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
paul.gottschling/2025-02-21-tabs HEAD 1 ✅SUCCEED paul-gottschling-2025-02-21-tabs 2025-02-21 20:38:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs dropdown menu doesn't switch properly
1 participant