Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): e2e for missing jobs #15910

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(server): e2e for missing jobs #15910

wants to merge 6 commits into from
+156 −16

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Feb 5, 2025 •
edited
Loading

A follow-up on #15864 that improves the e2e tests and adds tests for metadata and thumbnails

Adds slightly more logging to job queue actions

@etnoy etnoy force-pushed the fix/missing-thumbs branch from be01600 to 602230b Compare February 5, 2025 00:07
mertalev
mertalev reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't really fix anything. Metadata extraction is different because it's the first job that inserts into the job status table. The other jobs all expect metadata extraction to have run already, so there's nothing wrong with assuming there's a job status row for these assets.

@etnoy etnoy force-pushed the fix/missing-thumbs branch 2 times, most recently from 88b50f3 to 855c5ca Compare February 5, 2025 13:51
@etnoy etnoy changed the title fix(server): queue thumbs and faces feat(server): e2e for missing jobs Feb 5, 2025
@etnoy etnoy force-pushed the fix/missing-thumbs branch 4 times, most recently from dca3f96 to 1144737 Compare February 5, 2025 21:27
@etnoy etnoy force-pushed the fix/missing-thumbs branch from 1144737 to 53660aa Compare February 5, 2025 21:30
@etnoy
Copy link
Contributor Author

etnoy commented Feb 21, 2025

This PR doesn't really fix anything. Metadata extraction is different because it's the first job that inserts into the job status table. The other jobs all expect metadata extraction to have run already, so there's nothing wrong with assuming there's a job status row for these assets.

You are correct. I've redone this PR to just add e2e tests to metadata and jobs to ensure the correct behavior of the "all" and "missing" buttons.

@etnoy etnoy marked this pull request as ready for review February 21, 2025 21:37
@etnoy etnoy requested a review from mertalev February 21, 2025 21:37
@etnoy etnoy force-pushed the fix/missing-thumbs branch from 48b4aea to 12b5198 Compare February 21, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler Awaiting requested review from danieldietzler danieldietzler is a code owner

@mertalev mertalev Awaiting requested review from mertalev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog:bugfix 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etnoy @mertalev