Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask password from openvpn clients in debug logs. (user password from SSO accounts not affected) #416

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Feb 12, 2025

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

… SSO accounts not affected)

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (4b51d04) to head (bcf68d2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          50       50           
  Lines        2889     2889           
=======================================
  Hits         2400     2400           
  Misses        372      372           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkroepke jkroepke added the 🐞 bug Something isn't working label Feb 12, 2025
@jkroepke jkroepke merged commit cdf43cf into main Feb 12, 2025
8 of 9 checks passed
@jkroepke jkroepke deleted the mask branch February 12, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When logs are a DEBUG level we can observe user password in logs.
1 participant