-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Install Calico in kind for CI testing #2431
✨ Install Calico in kind for CI testing #2431
Conversation
Do you think you could upgrade the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented about adding an upgrade of the kind version in this PR.
2b2a7b4
to
1c93294
Compare
/test e2e-sharded |
/test-required |
TestDeploymentCoordinator "flake" /test-required |
TBF it seems more than a flake here, since it never succeeds. Wondering if something in the change breaks them. |
1c93294
to
b7c6236
Compare
@stevekuznetsov So do you confirm it is OK for you if we still merge this PR and @lionelvillard would create a follow-up PR for the changes you requested in this slack thread: https://kubernetes.slack.com/archives/C021U8WSAFK/p1672913451512589 ? |
I assume yes, as you mentioned here https://kubernetes.slack.com/archives/C021U8WSAFK/p1672931932256269?thread_ts=1672913451.512589&cid=C021U8WSAFK Let me approve then. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Summary
Default kind configuration does not support network policies. This PR modifies the kind configuration disabling kindnet and install Calico.
Related issue(s)
/cc @davidfestal