🐛 Fix and add test to capture a race w/ partial metadata in cache #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincepri
changed the title
ncdc
reviewed
Dec 16, 2022
Signed-off-by: Vince Prignano <[email protected]>
The API server handles tranforming the CRD when a client is asking for a partial metadata before objects are returned to the client. Moreover, modifying the CRD at this point can cause a race condition given that the spec will then be store in the cache. Signed-off-by: Vince Prignano <[email protected]>
|
@sttts is this ok to merge? |
|
e2e-shared-server flaked with #2501 |
|
prow e2e-sharded failure was flake #2507 |
|
/retest |
ncdc
approved these changes
Dec 16, 2022
|
/milestone v0.11 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
Summary
Fix should go in kcp/kubernetes (maybe?), this test captures the sequence of events leading up to the issue
Related issue(s)
Related to #2278
/cc @ncdc @stevekuznetsov @sttts