✨ Use distroless/static:debug as base image #2512
Conversation
| @@ -1,3 +1,5 @@ | |||
| # syntax=docker/dockerfile:1.4 | |||
There was a problem hiding this comment.
This is for completeness and to make sure clients don't assume the version
openshift-merge-robot
added
needs-rebase
Dockerfile
Outdated
| RUN apt-get update && apt-get install -y jq && mkdir bin | ||
|
|
||
| # Install kubectl. | ||
| ARG kubernetes_version=1.24.2 |
There was a problem hiding this comment.
(as a follow-up) is it possible to run go mod to get this value dynamically?
There was a problem hiding this comment.
Yeah we can do that with grep and whatnot, haven't found a clean way to set it
There was a problem hiding this comment.
$ go list -m -json k8s.io/kubernetes | jq .Version
"v1.24.3"
There was a problem hiding this comment.
Thanks! Added it to the Dockerfile
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
Signed-off-by: Vince Prignano <[email protected]>
|
/lgtm |
Signed-off-by: Vince Prignano [email protected]
Summary
This PR also adds support for better caching when building layers
Related issue(s)
Fixes #798