🐛 workload/resource: handle upsynced resources #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
jmprusi
force-pushed
the
jmprusi/upsync-scheduling-fix
branch
from
a79b7c4 to
b394ea4
Compare
ncdc
added
the
area/transparent-multi-cluster
jmprusi
force-pushed
the
jmprusi/upsync-scheduling-fix
branch
3 times, most recently
from
c926c2d to
6a79db2
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jmprusi
force-pushed
the
jmprusi/upsync-scheduling-fix
branch
6 times, most recently
from
a28b486 to
067a5c4
Compare
jmprusi
force-pushed
the
jmprusi/upsync-scheduling-fix
branch
3 times, most recently
from
4f95e36 to
1207ddc
Compare
davidfestal
reviewed
Feb 7, 2023
jmprusi
force-pushed
the
jmprusi/upsync-scheduling-fix
branch
from
1207ddc to
0f30c70
Compare
This PR fixes an issue with upsynced resources getting it's state changed into "Sync" when the initial synctarget is gone or unhealthy. If the resource is upsynced, check if the synctarget still exists, if not, delete the resource, if the synctarget still exists, do nothing, exit early.
jmprusi
force-pushed
the
jmprusi/upsync-scheduling-fix
branch
from
0f30c70 to
3e7ec62
Compare
davidfestal
approved these changes
Feb 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with upsynced resources getting it's state changed into "Sync" when the initial synctarget is gone or unhealthy.
If the resource is upsynced, check if the synctarget still exists, if not, delete the resource, if the synctarget still exists, do nothing, exit early.
Requires
Related issue(s)
Fixes #2530