Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add missing CGO_ENABLED flag in the install makefile target #2540

Merged
merged 1 commit into from
Jan 4, 2023
Merged

🐛 Add missing CGO_ENABLED flag in the install makefile target #2540

merged 1 commit into from
Jan 4, 2023

Conversation

lionelvillard
Copy link
Contributor

@lionelvillard lionelvillard commented Jan 4, 2023 •
edited
Loading

Summary

As per title

Related issue(s)

@openshift-ci openshift-ci bot requested review from davidfestal and ncdc January 4, 2023 14:35
@lionelvillard lionelvillard changed the title 🐛 Exclude static flag when building on macOS 🐛 Add missing CGO_ENABLED flag in the install makefile target Jan 4, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@vincepri
Copy link
Contributor

vincepri commented Jan 4, 2023

/retest

@lionelvillard
Copy link
Contributor Author

/test e2e-shared-server

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

@lionelvillard: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test boilerplate
  • /test codegen
  • /test deps
  • /test e2e
  • /test e2e-multiple-runs
  • /test e2e-sharded
  • /test e2e-shared
  • /test images
  • /test imports
  • /test lint
  • /test modules
  • /test test

Use /test all to run all jobs.

In response to this:

/test e2e-shared-server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lionelvillard
Copy link
Contributor Author

/test e2e-shared

@lionelvillard
Copy link
Contributor Author

/retest

@ncdc
Copy link
Member

ncdc commented Jan 4, 2023

Flake #2501

@openshift-merge-robot openshift-merge-robot merged commit 5db356a into kcp-dev:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionelvillard @vincepri @ncdc @openshift-merge-robot