🐛 Docker build/push should not use a matrix #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @ncdc |
astefanutti
reviewed
Jan 4, 2023
astefanutti
reviewed
Jan 4, 2023
.github/workflows/kcp-image.yaml
Outdated
| @@ -60,14 +54,14 @@ jobs: | |||
| type=raw,value=${{ env.sha_short }} | |||
There was a problem hiding this comment.
Not in the direct scope, but maybe an opportunity to have that replaced with type=sha,prefix=,suffix=,format=short so the logic that computes / sets sha_short can be removed.
By using a matrix github actions spins up different VMs to build these images, upon pushing tags and the manifest, the different VMs have no information about the other builds, so each build context will build and push a manifest only for its own image. Signed-off-by: Vince Prignano <[email protected]>
ncdc
approved these changes
Jan 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a matrix github actions spins up different VMs to build these images, upon pushing tags and the manifest, the different VMs have no information about the other builds, so each build context will build and push a manifest only for its own image.
Signed-off-by: Vince Prignano [email protected]
Summary
Related issue(s)
Fixes #