🌱 crdcleanup: strongly type enqueue params #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Goldstein <[email protected]>
ncdc
force-pushed
the
strongly-typed-enqueues/crdcleanup
branch
from
137fe6e to
2b25d26
Compare
stevekuznetsov
approved these changes
Jan 9, 2023
| @@ -80,33 +80,29 @@ func NewController( | |||
|
|
|||
| crdInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{ | |||
| FilterFunc: func(obj interface{}) bool { | |||
| crd, ok := obj.(*apiextensionsv1.CustomResourceDefinition) | |||
There was a problem hiding this comment.
Technically this is a regression in behavior but I think in practice it's the more correct thing to do anyway?
There was a problem hiding this comment.
Yes, but it's better to panic to indicate programmer error I'd say.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Strongly type the params used in our enqueue functions to avoid accidentally enqueueing the wrong kind of object.
Related issue(s)
Fixes #