Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 remove tenancy v1beta1 #2595

Conversation

stevekuznetsov
Copy link
Contributor

pkg/apis: add Workspace to tenancy.kcp.io/v1alpha1

Signed-off-by: Steve Kuznetsov [email protected]


*: use v1alpha1.Workspaces everywhere

Signed-off-by: Steve Kuznetsov [email protected]


*: remove tenancy.kcp.io/v1beta1

Signed-off-by: Steve Kuznetsov [email protected]


/assign @sttts @ncdc
Implements #2563

@openshift-ci openshift-ci bot assigned ncdc and sttts Jan 11, 2023
@openshift-ci openshift-ci bot requested review from csams and davidfestal January 11, 2023 15:28
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 11, 2023
@stevekuznetsov
Copy link
Contributor Author

Oops. need to handle some annotations

@stevekuznetsov stevekuznetsov force-pushed the skuznets/remove-tenancy-v1beta1 branch from 1852900 to d635995 Compare January 11, 2023 16:08
@stevekuznetsov
Copy link
Contributor Author

/retest

3 similar comments
@stevekuznetsov
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor Author

/retest

@stevekuznetsov stevekuznetsov force-pushed the skuznets/remove-tenancy-v1beta1 branch from d635995 to 444abcc Compare January 12, 2023 02:02
@ncdc
Copy link
Member

ncdc commented Jan 12, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@ncdc
Copy link
Member

ncdc commented Jan 12, 2023

/test e2e-shared

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit e5ce29a into kcp-dev:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants