Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Enable KUBE_CACHE_MUTATION_DETECTOR in e2e tests #2605

Merged
merged 1 commit into from
Jan 12, 2023
Merged

🌱 Enable KUBE_CACHE_MUTATION_DETECTOR in e2e tests #2605

merged 1 commit into from
Jan 12, 2023

Conversation

vincepri
Copy link
Contributor

Signed-off-by: Vince Prignano [email protected]

Summary

Related issue(s)

Fixes #1134

@vincepri vincepri changed the title Enable KUBE_CACHE_MUTATION_DETECTOR in e2e tests 🌱 Enable KUBE_CACHE_MUTATION_DETECTOR in e2e tests Jan 11, 2023
@openshift-ci openshift-ci bot requested review from csams and davidfestal January 11, 2023 22:28
@stevekuznetsov
Copy link
Contributor

 test/e2e/framework/kcp.go:194:66: not enough arguments in call to require.NoError
	have (error)
	want (require.TestingT, error, ...interface{}) (typecheck)
			require.NoError(os.Setenv("KUBE_CACHE_MUTATION_DETECTOR", "1"))
			                                                              ^ 

@stevekuznetsov
Copy link
Contributor

        CACHE *v1.ClusterRole[91] ALTERED!
        (*v1.ClusterRole)(0xc0020b7b80)({                                                       (*v1.ClusterRole)(0xc0020b7cc0)({
         TypeMeta: (v1.TypeMeta) {                                                               TypeMeta: (v1.TypeMeta) {
          Kind: (string) "",                                                                      Kind: (string) "",
          APIVersion: (string) ""                                                                 APIVersion: (string) ""
         },                                                                                      },

💥

@ncdc
Copy link
Member

ncdc commented Jan 12, 2023

Yeah that's what #2604 is fixing

@vincepri
Copy link
Contributor Author

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 372d5d3 into kcp-dev:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable cache mutation detector when running tests
4 participants