🐛 Use APIExport cluster names within webhooks #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nolan Brubaker <[email protected]>
openshift-ci
bot
added
the
kind/api-change
|
At least one valid failure, not flakes. |
ncdc
reviewed
Jan 17, 2023
ncdc
reviewed
Jan 19, 2023
nrb
force-pushed
the
fix-2622
branch
3 times, most recently
from
ebbc24d to
03a9be0
Compare
ncdc
reviewed
Jan 19, 2023
ncdc
reviewed
Jan 19, 2023
ncdc
reviewed
Jan 19, 2023
ncdc
reviewed
Jan 19, 2023
ncdc
reviewed
Jan 19, 2023
nrb
commented
Jan 19, 2023
ncdc
reviewed
Jan 19, 2023
ncdc
reviewed
Jan 19, 2023
Signed-off-by: Nolan Brubaker <[email protected]>
ncdc
approved these changes
Jan 19, 2023
openshift-ci
bot
added
lgtm
Signed-off-by: Nolan Brubaker <[email protected]>
|
Possible flakes on /retest |
sttts
reviewed
Jan 23, 2023
Signed-off-by: Nolan Brubaker <[email protected]>
ncdc
approved these changes
Jan 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Look up APIExports by name, not path, within the generic webhook.
Adds a new required field that the APIBinding reconciler sets:
APIBinding.Status.LogicalCluster.Related issue(s)
Fixes #2622