🌱 test/e2e: DRY up waiting on conditions #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/eventually-condition
branch
from
36791c0 to
71d268e
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Probably can follow-up with a summary of all conditions in the case where we can't find the one that is being waited on - if we ensure a stable sort order for those, they will de-dupe correctly in the |
stevekuznetsov
force-pushed
the
skuznets/eventually-condition
branch
3 times, most recently
from
6b4e424 to
18b3d1a
Compare
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/eventually-condition
branch
from
dd7e3a4 to
1f3b590
Compare
openshift-merge-robot
removed
the
needs-rebase
ncdc
approved these changes
Feb 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kuznetsov [email protected]
/assign @ncdc