🐛 Fix Makefile clean target and add .kcp cleanup #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @p0lyn0mial |
|
I would recommend also adding a new target to just clean the |
Thanks - I added a |
ncdc
reviewed
Jan 31, 2023
added 2 commits
February 1, 2023 09:56
The wildcard in the GOBIN_DIR test means this currently fails
This means it's easier to run e2e tests locally with a clean starting point e.g make clean-workdir test-e2e-sharded-minimal
|
/test e2e-sharded |
ncdc
approved these changes
Feb 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
cleantarget was added in #2562 but doesn't currently work due to the wildcard in theGOBIN_DIRtest.Also following some discussion on slack about cleanup for the
.kcp*directories I added cleanup so we can more easily switch between e.g shared/sharded e2e tests locally e.gmake clean test-e2e-sharded-minimal