-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Small improvements to dev workflow #2753
🌱 Small improvements to dev workflow #2753
Conversation
Hi @fabriziopandini. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Just a couple of minor nits |
df3012b
to
a43bada
Compare
@ncdc thanks for the quick feedback! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Proposing a small change to the Makefile so it is possible to do
KIND_CLUSTER_NAME=foo build-kind-images
Which is nice to have when testing scheduling on multiple clusters.
Also, proposing to have a tmp folder in .gitignore where each developer can store temporary files, and get rid of .DS_Store files on mac.
Related issue(s)
Fixes #