Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 tmc e2e: fix Syncer virtual workspace e2e test flakes #2767

Merged

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Feb 8, 2023

Summary

TMC E2E: Attempt at fixing Syncer virtual workspace e2e test flakes.
Not sure it would fix them all, but at east it fixes a possible cause, and increases log details (through the use of framework.Eventually instead of require.Eventually

Related issue(s)

Fixes #

... until the TMC e2e tests are made shard-aware.

Signed-off-by: David Festal <[email protected]>
@openshift-ci openshift-ci bot requested review from kylape and qiujian16 February 8, 2023 18:30
@davidfestal
Copy link
Member Author

/retest

1 similar comment
@ncdc
Copy link
Member

ncdc commented Feb 8, 2023

/retest

... everywhere in the Syncer VW tests.
This will help in hunting the flakes.

Signed-off-by: David Festal <[email protected]>
@ncdc
Copy link
Member

ncdc commented Feb 8, 2023

/retest

1 similar comment
@davidfestal
Copy link
Member Author

/retest

@davidfestal davidfestal changed the title 🐛 [WIP] tmc e2e: fix Syncer virtual workspace e2e test flakes 🐛 tmc e2e: fix Syncer virtual workspace e2e test flakes Feb 8, 2023
@davidfestal
Copy link
Member Author

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

@davidfestal: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test boilerplate
  • /test codegen
  • /test deps
  • /test e2e
  • /test e2e-multiple-runs
  • /test e2e-sharded
  • /test e2e-shared
  • /test images
  • /test imports
  • /test lint
  • /test modules
  • /test test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidfestal
Copy link
Member Author

/test e2e
/test e2e-multiple-runs
/test e2e-sharded
/test e2e-shared

@davidfestal
Copy link
Member Author

re-running the e2e tests several times to checks for flakes.

@davidfestal
Copy link
Member Author

@ncdc if the tests pass again this time would you approve ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5ebd7bf into kcp-dev:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants