Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Ready column to APIBinding and APIExport #2851

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mjudeikis
Copy link
Contributor

Summary

Adds column for readiness of apibinding and apiexport:

[mjudeikis@unknown2 kcp]$ k get apiexport 
NAME                 AGE   READY
apiresource.kcp.io   13d   True
scheduling.kcp.io    13d   True
shards.core.kcp.io   13d   True
tenancy.kcp.io       13d   True
topology.kcp.io      13d   True
workload.kcp.io      13d   True
[mjudeikis@unknown2 kcp]$ k get apibinding
NAME                 AGE   READY
apiresource.kcp.io   13d   True
scheduling.kcp.io    13d   True
shards.core.kcp.io   13d   True
tenancy.kcp.io       13d   True
topology.kcp.io      13d   True
workload.kcp.io      13d   True

Related issue(s)

Fixes #2182

@openshift-ci openshift-ci bot requested review from ncdc and sttts March 1, 2023 09:14
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Mar 1, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3db62fb into kcp-dev:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add status column to APIBinding/APIExports CLI
3 participants