-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 split pkg/client
with go workspaces
#2869
Conversation
Skipping CI for Draft Pull Request. |
pkg/client
with go workspacespkg/client
with go workspaces
f6fdc91
to
ebebab3
Compare
/retest |
312205a
to
d23d9a2
Compare
Will review more thoroughly later, but one thing I wanted to mention quickly is about go.work. I don't think we want to check that in to the repo? I think that's usually something developers could/would customize locally. I'd actually probably add it to .gitignore... |
We should be able to keep it as 0.0.0 in the repo and not need to replace it with the published version. |
Got ya. I think you can ignore this until Ci is green. Neet to nurture it down until all parts works ;/ |
c767064
to
de794aa
Compare
cleaned the root go.mod to be minimal change. All the other child go.mod are just being aligned with root one now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Split
pkg/client
to separate the moduleFollow-up PR will be needed to replace with real version once we publish first version
Related issue(s)
Fixes #2794
Supersedes #2676
Supersedes #2192