🐛 Remove root:compute deps in controller #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold still working on fixing the e2e test.. |
openshift-ci
bot
added
the
do-not-merge/hold
davidfestal
reviewed
Mar 8, 2023
pkg/reconciler/workload/apiexport/workload_apiexport_controller.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/apiexport/workload_apiexport_reconcile.go
Outdated
Show resolved
Hide resolved
openshift-ci
bot
added
the
kind/api-change
openshift-merge-robot
added
the
needs-rebase
qiujian16
force-pushed
the
rm-root-compute
branch
from
80058d7 to
e7dde71
Compare
openshift-merge-robot
added
needs-rebase
qiujian16
force-pushed
the
rm-root-compute
branch
from
e7dde71 to
155d814
Compare
openshift-merge-robot
removed
the
needs-rebase
qiujian16
force-pushed
the
rm-root-compute
branch
5 times, most recently
from
d8c93af to
b31c96a
Compare
| for _, resource := range resourceToSync { | ||
| nameParts := strings.SplitN(resource, ".", 2) | ||
| resourceName := nameParts[0] | ||
| apiGroup := "core" |
There was a problem hiding this comment.
Is this a constant we can import?
There was a problem hiding this comment.
Do you mean, should we use:
corev1.GenericControlPlaneGroupName ?
Even in the kubernetes fork, it doesn't seem to be used in such cases. Here is an example of those:
pkg/reconciler/workload/apiexport/workload_apiexport_reconcile.go
Outdated
Show resolved
Hide resolved
qiujian16
force-pushed
the
rm-root-compute
branch
3 times, most recently
from
85c6c3e to
e54daad
Compare
ncdc
added
the
area/transparent-multi-cluster
davidfestal
reviewed
Mar 14, 2023
tmc/pkg/virtual/syncer/controllers/apireconciler/syncer_apireconciler_indexes.go
Outdated
Show resolved
Hide resolved
davidfestal
reviewed
Mar 14, 2023
pkg/reconciler/workload/apiexport/workload_apiexport_reconcile.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/apiexport/workload_apiexport_reconcile.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/apiexport/workload_apiexport_reconcile.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/synctargetexports/synctarget_indexes.go
Outdated
Show resolved
Hide resolved
qiujian16
force-pushed
the
rm-root-compute
branch
2 times, most recently
from
61964de to
fa3c22a
Compare
|
@qiujian16 there's still a test failing. |
qiujian16
force-pushed
the
rm-root-compute
branch
3 times, most recently
from
efa78a8 to
9d3be02
Compare
qiujian16
force-pushed
the
rm-root-compute
branch
from
9d3be02 to
7644e05
Compare
|
/test e2e-sharded |
davidfestal
reviewed
Mar 29, 2023
davidfestal
reviewed
Mar 29, 2023
qiujian16
force-pushed
the
rm-root-compute
branch
from
e584b2f to
c41ff68
Compare
|
/lgtm |
sttts
reviewed
Mar 29, 2023
qiujian16
force-pushed
the
rm-root-compute
branch
from
c41ff68 to
22e9551
Compare
1. create imported-api APIExport during sync cmd if resources flag is set 2. controller updated imported-api APIExport with updated APIResourceSchema 3. remove auto-generated apibinding 4. add a validation on sync command to avoid setting imported-apis in --api-export flag Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
rm-root-compute
branch
from
22e9551 to
ed885aa
Compare
|
/lgtm |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
stevekuznetsov
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #2625