Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Consolidate API and client into single module/package #2894

Merged
merged 4 commits into from
Mar 28, 2023
Merged

⚠️ Consolidate API and client into single module/package #2894

merged 4 commits into from
Mar 28, 2023

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Mar 14, 2023 •
edited
Loading

Summary

Migrate client and apis into single module sdk
Change all imports and generators to use SDK for generated content

TODO:

  1. merge and tag SDK module
  2. Move apigen to use new SDK module

Related issue(s)

Fixes #2892

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Mar 14, 2023
@mjudeikis mjudeikis force-pushed the sdk.pkg branch 3 times, most recently from 7cbc8e9 to 81d02e6 Compare March 15, 2023 09:36
@mjudeikis mjudeikis marked this pull request as ready for review March 15, 2023 10:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@openshift-ci openshift-ci bot requested review from csams and davidfestal March 15, 2023 10:32
@mjudeikis
Copy link
Contributor Author

/retest

mjudeikis
mjudeikis commented Mar 16, 2023
View reviewed changes
cmd/apigen/go.mod
github.com/google/go-cmp v0.5.5
github.com/kcp-dev/kcp/pkg/apis v0.10.1-0.20230123155139-7b3126cbf96c
github.com/google/go-cmp v0.5.9
github.com/kcp-dev/kcp/pkg/apis v0.11.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be follow-up to move to new SDK modules once we tag it

@ncdc
Copy link
Member

ncdc commented Mar 16, 2023

/lgtm
@stevekuznetsov or @sttts any reason to hold off?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023
@ncdc
Copy link
Member

ncdc commented Mar 27, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/retest

github is having a bad bad day

@ncdc
Copy link
Member

ncdc commented Mar 27, 2023

It's our CI env's DNS. Not sure if they've fixed it yet.

@mjudeikis
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
@ncdc
Copy link
Member

ncdc commented Mar 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 75bb452 into kcp-dev:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csams csams Awaiting requested review from csams

@davidfestal davidfestal Awaiting requested review from davidfestal

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: API dependecy on client pkg
3 participants
@mjudeikis @ncdc @openshift-merge-robot