🐛 Disable default apiserver timeout (60s) for Syncer tunnel connection #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
reviewed
Mar 15, 2023
jmprusi
force-pushed
the
jmprusi/longrunning_tunnel
branch
from
000d703 to
6aed18b
Compare
ncdc
reviewed
Mar 15, 2023
jmprusi
force-pushed
the
jmprusi/longrunning_tunnel
branch
from
6aed18b to
3ad9fb9
Compare
ncdc
reviewed
Mar 15, 2023
jmprusi
force-pushed
the
jmprusi/longrunning_tunnel
branch
from
3ad9fb9 to
cbc665a
Compare
ncdc
approved these changes
Mar 15, 2023
stevekuznetsov
approved these changes
Mar 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the tunnel subresource (used by the syncer reverse tunnel) to the
LongRunningFuncfilter function. That is done to avoid the default timeout of 60s when accessing the tunnel subresource; this will fix the current issue where the Syncer tunnel is disconnected every minute, improving the end-user experience when accessing pods logs/exec...Related issue(s)
Fixes #2886