Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Update to Kubernetes 1.26.3 #2956

Merged
merged 22 commits into from
May 19, 2023
Merged

✨ Update to Kubernetes 1.26.3 #2956

merged 22 commits into from
May 19, 2023

Conversation

sttts
Copy link
Member

@sttts sttts commented May 17, 2023 •
edited
Loading

Continuation of #2945.

Most kudos by far to @ncdc.

@ncdc
go.mod: prepare for k8s 1.26
0bfbfa0 
Add new staging repos to prepare for bumping k8s to 1.26

Signed-off-by: Andy Goldstein <[email protected]>
@openshift-ci openshift-ci bot requested review from csams and davidfestal May 17, 2023 15:15
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 17, 2023
@sttts
Copy link
Member Author

sttts commented May 17, 2023

Only TestAPIBindingMutatingWebhook failed in sharded prow job. Shared prow job was green.

/retest

@sttts
Copy link
Member Author

sttts commented May 17, 2023

/retest

@sttts
Copy link
Member Author

sttts commented May 17, 2023

Repeatingly failing TestAPIBindingValidatingWebhook.

@sttts
Copy link
Member Author

sttts commented May 17, 2023

Again TestAPIBindingValidatingWebhook.

/retest

@sttts sttts mentioned this pull request May 19, 2023
Closed
5 tasks
@sttts sttts force-pushed the sttts-1.26 branch 3 times, most recently from cadf1c2 to 5155227 Compare May 19, 2023 09:13
@sttts sttts changed the title 🌱 DEBUG: 1.26 rebase with some reverts Update to Kubernetes 1.26.3 May 19, 2023
@sttts
Copy link
Member Author

sttts commented May 19, 2023

Infra issue

/retest

ncdc and others added 12 commits May 19, 2023 12:26
@ncdc @sttts
Update sub modules to k8s 1.26.3
661ba36 
Signed-off-by: Andy Goldstein <[email protected]>
@sttts
go mod tidy
942c903
@ncdc @sttts
make codegen
cb096da 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
React to k8s 1.26
937bd29 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Fix deprecated pointer.* calls
93e6b66 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Fix deprecated sets.String usage
999b40f 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Add placeholder for AddEventHandler return values
6c9a772 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Switch to generic sets.Set
63a2be3 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Fix gocritic issue
f34720d 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Fix remaining lint issues
6f903d4 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Update imports
22baf90 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc @sttts
Update codegen
2a7a29c 
Signed-off-by: Andy Goldstein <[email protected]>
@sttts sttts changed the title Update to Kubernetes 1.26.3 ✨ Update to Kubernetes 1.26.3 May 19, 2023
@sttts
Copy link
Member Author

sttts commented May 19, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
@sttts
Copy link
Member Author

sttts commented May 19, 2023

Infra issue again: failed to get object after finishing watch error=pods "e2e-multiple-runs-e2e-multiple-runs" not found

/retest

@sttts
Copy link
Member Author

sttts commented May 19, 2023

Pre-existing TestSyncingFromMultipleShards flake. We will delete this functionality soonish. So ignoring.

/retest

@sttts
Copy link
Member Author

sttts commented May 19, 2023

Infra flake

/retest

@sttts
Copy link
Member Author

sttts commented May 19, 2023

/retest

@ncdc
Copy link
Member

ncdc commented May 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
ncdc and others added 9 commits May 19, 2023 15:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@ncdc
Copy link
Member

ncdc commented May 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit 88d6071 into kcp-dev:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csams csams Awaiting requested review from csams

@davidfestal davidfestal Awaiting requested review from davidfestal

Assignees

@ncdc ncdc

@xrstf xrstf

@scheeles scheeles

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sttts @ncdc @xrstf @scheeles @openshift-merge-robot