⚠️ Remove TMC/Syncer #2963
Merged
⚠️ Remove TMC/Syncer #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/api-change
xrstf
force-pushed
the
remove-syncer
branch
4 times, most recently
from
4df1bd8 to
52b5279
Compare
xrstf
force-pushed
the
remove-syncer
branch
2 times, most recently
from
2754884 to
11e1ffa
Compare
sttts
reviewed
Jun 1, 2023
| @@ -51,9 +49,7 @@ go install "${CODEGEN_PKG}"/cmd/client-gen | |||
| --input github.com/kcp-dev/kcp/sdk/apis/apiresource/v1alpha1 \ | |||
There was a problem hiding this comment.
Wondering about apiresource. It will probably go too, but this should be a second step.
sttts
reviewed
Jun 1, 2023
sttts
reviewed
Jun 1, 2023
sttts
reviewed
Jun 1, 2023
sttts
reviewed
Jun 1, 2023
|
openshift/release#39918 should remove the parts of the CI configuration that make this PR break right now. Until that is merged, I guess this PR is blocked unless we want to add dummy contents back into this repo to make the jobs pretend to work. |
|
/retest |
|
/test e2e-multiple-runs |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This supersedes #2955, which would have to be rebased and was also removing such a small portion that it's effectively meaningless.
Part of #2954.