Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add Prowjobs #2975

Merged
merged 2 commits into from
Jun 6, 2023
Merged

🌱 Add Prowjobs #2975

merged 2 commits into from
Jun 6, 2023
+180 −5

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 6, 2023 •
edited
Loading

Summary

This moves the Prowjobs that were previously part of the openshift/release repo into a simple in-repo configuration (i.e. a .prow.yaml).

I combined the various verify tasks into a single pull-kcp-verify job, but had to pull the codegen task out into its own Prow job, as running it as part of other tasks seems to make it get stuck and I have not further investigated why. client-gen seems to just sit forever (I checked the pod, CPU usage was basically idling).

part of kcp-dev/infra#43

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jun 6, 2023
@openshift-ci openshift-ci bot requested review from clubanderson and scheeles June 6, 2023 18:05
@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2023
@xrstf xrstf changed the title WIP - 🌱 Add Prowjobs 🌱 WIP - Add Prowjobs Jun 6, 2023
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2023
@xrstf xrstf force-pushed the add-prowjobs branch 3 times, most recently from d4d9d76 to 4555193 Compare June 6, 2023 18:36
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2023
@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

/retest

1 similar comment
@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

/retest

@xrstf xrstf changed the title 🌱 WIP - Add Prowjobs 🌱 Add Prowjobs Jun 6, 2023
@xrstf xrstf requested review from sttts and removed request for clubanderson and scheeles June 6, 2023 20:34
@sttts
Copy link
Member

sttts commented Jun 6, 2023

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d41be6ba6c8013965e079daaebe14d40174ca353

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Member

sttts commented Jun 6, 2023

How can we set the required jobs? Just manually or is there something in prow?

@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

All jobs that were executed are required by default, unless a job has optional: true set in the .prow.yaml. On Github's end all we need to do is make tide a required status check.

@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

Until the openshift jobs disappear, I guess we have to manually /override them individually in each PR.

@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

/override ci/prow/boilerplate
/override ci/prow/codegen
/override ci/prow/deps
/override ci/prow/images
/override ci/prow/imports
/override ci/prow/lint
/override ci/prow/modules
/override ci/prow/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/boilerplate, ci/prow/codegen, ci/prow/deps, ci/prow/images, ci/prow/imports, ci/prow/lint, ci/prow/modules, ci/prow/test

In response to this:

/override ci/prow/boilerplate
/override ci/prow/codegen
/override ci/prow/deps
/override ci/prow/images
/override ci/prow/imports
/override ci/prow/lint
/override ci/prow/modules
/override ci/prow/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@kcp-ci-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/boilerplate, ci/prow/codegen, ci/prow/deps, ci/prow/images, ci/prow/imports, ci/prow/lint, ci/prow/modules, ci/prow/test

In response to this:

/override ci/prow/boilerplate
/override ci/prow/codegen
/override ci/prow/deps
/override ci/prow/images
/override ci/prow/imports
/override ci/prow/lint
/override ci/prow/modules
/override ci/prow/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor Author

xrstf commented Jun 6, 2023

/override ci/prow/e2e
/override ci/prow/e2e-multiple-runs
/override ci/prow/e2e-sharded
/override ci/prow/e2e-shared

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/e2e, ci/prow/e2e-multiple-runs, ci/prow/e2e-sharded, ci/prow/e2e-shared

In response to this:

/override ci/prow/e2e
/override ci/prow/e2e-multiple-runs
/override ci/prow/e2e-sharded
/override ci/prow/e2e-shared

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot merged commit b4f6760 into kcp-dev:main Jun 6, 2023
@kcp-ci-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: ci/prow/e2e, ci/prow/e2e-multiple-runs, ci/prow/e2e-sharded, ci/prow/e2e-shared

In response to this:

/override ci/prow/e2e
/override ci/prow/e2e-multiple-runs
/override ci/prow/e2e-sharded
/override ci/prow/e2e-shared

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf deleted the add-prowjobs branch June 6, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @sttts @kcp-ci-bot