✨ Add admin battery to kcp server and enable it by default
#3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
release-note
embik
changed the title
admin battery to kcp server and enable it by default
|
/lgtm |
|
LGTM label has been added. Git tree hash: b906b3e3e89b5364ff07f73bd9a999dd39f57ebb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
I guess this might not be a flake. |
|
/retest |
1 similar comment
|
/retest |
|
/kind feature |
kcp-ci-bot
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #3033 and the discussion it created. This new approach adds a new battery called
adminand enables it by default. Without this battery,admin.kubeconfigwill not be generated and no admin token will be created to be injected into a new authenticator.I've also added a check to make sure that the
userbattery is not enabled whenadminis not.Related issue(s)
Fixes #
Release Notes