✨ Simplify index pkg #3056
Merged
✨ Simplify index pkg #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note
mjudeikis
commented
Dec 9, 2023
kcp-ci-bot
added
do-not-merge/work-in-progress
mjudeikis
force-pushed
the
mjudeikis/index.simplify
branch
from
a1cad54 to
dd9f145
Compare
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
mjudeikis
force-pushed
the
mjudeikis/index.simplify
branch
from
dd9f145 to
323486f
Compare
|
/retest |
mjudeikis
force-pushed
the
mjudeikis/index.simplify
branch
from
323486f to
fb3dd93
Compare
kcp-ci-bot
added
do-not-merge/release-note-label-needed
|
@sttts the first PR in mounts saga. ready to review. Closed other as it was changing too much. Now have stable branch, so gonna start moving them bit by bit |
kcp-ci-bot
added
release-note
|
/lgtm |
|
LGTM label has been added. Git tree hash: badfa8c09f6050d57970814e34523179a52a8a92
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
sttts
reviewed
Dec 13, 2023
| @@ -28,8 +28,17 @@ import ( | |||
|
|
|||
| // Index implements a mapping from logical cluster to (shard) URL. | |||
| type Index interface { | |||
| Lookup(path logicalcluster.Path) (shard string, cluster, canonicalPath logicalcluster.Path, found bool) | |||
| LookupURL(logicalCluster logicalcluster.Path) (url string, canonicalPath logicalcluster.Path, found bool) | |||
| Lookup(path logicalcluster.Path) Result | |||
There was a problem hiding this comment.
for follow-up, maybe Result, bool is more canonical.
|
/kind feature |
kcp-ci-bot
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify index package and wire in the ability to forward to different URLs. For now only in insecure mode in dev, as we need to wire in certificates deeper into stack. This is preparation for the experimental feature "workspace mounts"
Follow-up PR will follow: #3057
Related issue(s)
Fixes #
Release Notes