Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add optional nameValidation field to ApiResourceSchemaSpec #3082

Merged
merged 1 commit into from
Feb 19, 2024
Merged

✨ Add optional nameValidation field to ApiResourceSchemaSpec #3082

merged 1 commit into from
Feb 19, 2024

Conversation

praveenrewar
Copy link
Contributor

@praveenrewar praveenrewar commented Feb 16, 2024 •
edited
Loading

Summary

Add optional nameValidation field to ApiResourceSchemaSpec.
This field is propagated to the bound crd and the name validation strategy is decided based on the value.
Related slack thread.

Related issue(s)

Fixes #

Release Notes

Add optional nameValidation field to ApiResourceSchemaSpec. This field is used to add an internal annotation to the bound API and the name validation strategy is decided based on the value.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @praveenrewar. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2024
@praveenrewar praveenrewar force-pushed the apiresourceschema-namevalidation branch from 5dd772a to 457006b Compare February 18, 2024 13:40
@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2024
@sttts
Copy link
Member

sttts commented Feb 18, 2024

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2024
@praveenrewar praveenrewar force-pushed the apiresourceschema-namevalidation branch 2 times, most recently from 1d5b602 to 8949747 Compare February 18, 2024 18:19
@praveenrewar praveenrewar changed the title WIP ✨ Add optional nameValidation field to ApiResourceSchemaSpec ✨ Add optional nameValidation field to ApiResourceSchemaSpec Feb 19, 2024
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@praveenrewar
Add optional nameValidation field to ApiResourceSchemaSpec
b6ee169 
This field is used to add an internal annotation to the bound API and the name validation strategy is decided based on the value.

Signed-off-by: Praveen Rewar <[email protected]>
@praveenrewar praveenrewar force-pushed the apiresourceschema-namevalidation branch from 8949747 to b6ee169 Compare February 19, 2024 13:30
@praveenrewar
Copy link
Contributor Author

/test pull-kcp-test-e2e-shared

@praveenrewar
Copy link
Contributor Author

/retest

@sttts
Copy link
Member

sttts commented Feb 19, 2024

/lgtm
/approve

🎉, thanks for the contribution.

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bcd5c21968d615cc248602043c864701333fa2b6

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@kcp-ci-bot kcp-ci-bot merged commit d9dc3d0 into kcp-dev:main Feb 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenrewar @kcp-ci-bot @sttts