-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Index mounting ordering & few debug nits #3085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9d6799
to
a78f9d2
Compare
sttts
reviewed
Mar 8, 2024
sttts
reviewed
Mar 8, 2024
Signed-off-by: Mangirdas Judeikis <[email protected]>
3ce3ea7
to
608dd2d
Compare
608dd2d
to
be09ec7
Compare
be09ec7
to
b35878c
Compare
/lgtm |
LGTM label has been added. Git tree hash: 2e78003c68c0581c6433186cbccf51d0aebf1af8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
dco-signoff: yes
Indicates the PR's author has signed the DCO.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does few things:
kubectl-ws '~'
changes hostname used in kubeconfig server URL #3011In general, it dynamically overrides mounts URLs (this was not done before), and matches them in order of length. Higher the weight (
weight = length of the path
) first it will get matches.Without this, map is randomly selected and if you have 2 mappings with
your traffic will be randomized :)
Related issue(s)
Fixes #
Release Notes