✨ Webhook URL based CRD conversions #3090
Conversation
kcp-ci-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
the
size/L
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
Signed-off-by: Nabarun Pal <[email protected]>
…PIResourceSchema to CRD Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
feat/url-based-crd-conversions
branch
from
faabb18 to
750a91d
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: d47a691bef1dde6131d5aa5ab483021e8354a343
|
| @@ -541,5 +538,27 @@ func generateCRD(schema *apisv1alpha1.APIResourceSchema) (*apiextensionsv1.Custo | |||
| crd.Spec.Versions = append(crd.Spec.Versions, crdVersion) | |||
| } | |||
|
|
|||
| if len(schema.Spec.Versions) > 1 && schema.Spec.Conversion == nil { | |||
There was a problem hiding this comment.
do we have validation in place that check this? Here we are pretty late in the process.
There was a problem hiding this comment.
We don't at the moment. This should either be in admission or checked through a CEL expression in the APIResourceSchema. What do you think?
There was a problem hiding this comment.
If CEL, this might be an option: size(self.versions) == 1 || (size(self.versions) > 1 && has(self.conversion))
There was a problem hiding this comment.
Not sure if one can put a Kubebuilder validation on the spec field? Never tried.
There was a problem hiding this comment.
Added this in the latest commit and verified by trying to create a CRD.
Signed-off-by: Nabarun Pal <[email protected]>
kcp-ci-bot
added
size/XL
…nform APIResourceSchema to CRD Signed-off-by: Nabarun Pal <[email protected]>
Signed-off-by: Nabarun Pal <[email protected]>
|
/lgtm |
|
LGTM label has been added. Git tree hash: b71145a26a52ec2a9a4ff9e77124e695438ef055
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Summary
An attempt to add webhook URL based CRD conversions with/without a custom CA.
Changeset
The conversion works for CRDs created manually, just like Kubernetes. For CRDs created from API bindings, no more plumbing is required.
Related issue(s)
None
Release Notes