Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add architecture brain-dump. #3108

Merged
merged 2 commits into from
Apr 6, 2024
Merged

📖 Add architecture brain-dump. #3108

merged 2 commits into from
Apr 6, 2024

Conversation

sttts
Copy link
Member

@sttts sttts commented Apr 1, 2024

Summary

This text was an attempt/experiment to teach GPT about KCP's concept and make it write a summarizing text about it. The success of this was limited, but the dictated text might be of use to understand KCP better.

Related issue(s)

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2024
@sttts sttts force-pushed the sttts-brain-dump branch 3 times, most recently from c74f6aa to 7ed149a Compare April 1, 2024 10:30
@sttts
docs: add an architecture brain dump
d2e54f8 
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@sttts sttts force-pushed the sttts-brain-dump branch from 7ed149a to d2e54f8 Compare April 1, 2024 10:31
embik
embik requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of notes on formatting issues. In general, i think this needs more paragraphs, but it's something we should absolutely merge for the treasure trove of knowledge that it is. Paragraphs can always be added later.

@sttts
Address comments
7c33856 
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
embik
embik approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f0c7749f28bac74d87a0f0d22e4a9a2728ffd3ae

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2024
@kcp-ci-bot kcp-ci-bot merged commit bd87147 into kcp-dev:main Apr 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sttts @kcp-ci-bot @embik