✨ apiexports: make SubjectAccessReview and LocalSubjectAccessReview claimable #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
sttts
force-pushed
the
sttts-claimable-sar
branch
from
fc6ef2a to
c4968f2
Compare
kcp-ci-bot
added
release-note
sttts
changed the title
sttts
force-pushed
the
sttts-claimable-sar
branch
from
c4968f2 to
960c19a
Compare
sttts
changed the title
sttts
force-pushed
the
sttts-claimable-sar
branch
2 times, most recently
from
4a168e5 to
b6aa26c
Compare
kcp-ci-bot
added
kind/api-change
sttts
force-pushed
the
sttts-claimable-sar
branch
7 times, most recently
from
bd22196 to
a668fb8
Compare
palnabarun
reviewed
May 10, 2024
Comment on lines
171
to
173
| Cluster string `json:"cluster,omitempty"` | ||
| Cluster logicalcluster.Name `json:"cluster,omitempty"` |
There was a problem hiding this comment.
Isn't this a breaking change? We should add a release note in that case.
Comment on lines
145
to
147
| APIExportClusterName string `json:"apiExportClusterName,omitempty"` | ||
| APIExportClusterName logicalcluster.Name `json:"apiExportClusterName,omitempty"` |
There was a problem hiding this comment.
Isn't this also a breaking change?
|
/approve |
kcp-ci-bot
added
the
approved
|
/lgtm |
kcp-ci-bot
added
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 639c33e94ca9c31d969b39dfa3e9dc2f1d9b291e
|
sttts
force-pushed
the
sttts-claimable-sar
branch
from
950f6ce to
dfa49fd
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
kcp-ci-bot
removed
the
do-not-merge/hold
…imable Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-claimable-sar
branch
from
dfa49fd to
f0932b9
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 7bce21f906065ed9dd7ca3c4c78a26eda33a3d50
|
|
late /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The list of native resources that are claimable is static and defined at https://github.com/kcp-dev/kcp/blob/main/pkg/virtual/apiexport/schemas/builtin/builtin.go#L88.
This PR adds
SubjectAccessReviewandLocalSubjectAccessReviewto that list.Related issue(s)
Release Notes