Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 authorization/delegated: fix typo leading to zero deny cache ttl #3163

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

sttts
Copy link
Member

@sttts sttts commented Sep 16, 2024

Summary

A typo led to a zero ttl for the deny cache of delegated authz.

Related issue(s)

Fixes #

Release Notes

Fix performance problem in virtual workspace authorization.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2024
@sttts
Copy link
Member Author

sttts commented Sep 16, 2024

/approve

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
Copy link

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@kcp-ci-bot
Copy link
Contributor

@phisco: changing LGTM is restricted to collaborators

In response to this:

good catch!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6ae3a89da29a6fce14cae3413890caf9a559983

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@kcp-ci-bot kcp-ci-bot requested a review from embik September 16, 2024 10:19
@kcp-ci-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2024
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@sttts sttts force-pushed the sttts-delegated-auth-typo branch from c0fcbfc to 145f6bc Compare September 16, 2024 10:21
@sttts sttts added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@kcp-ci-bot kcp-ci-bot merged commit 4e00e7b into kcp-dev:main Sep 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants