-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 authorization/delegated: fix typo leading to zero deny cache ttl #3163
Conversation
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
@phisco: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: b6ae3a89da29a6fce14cae3413890caf9a559983
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
c0fcbfc
to
145f6bc
Compare
Summary
A typo led to a zero ttl for the deny cache of delegated authz.
Related issue(s)
Fixes #
Release Notes