Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby v4 upgrade #195

Merged
merged 22 commits into from
Feb 10, 2022
Merged

Gatsby v4 upgrade #195

merged 22 commits into from
Feb 10, 2022

Conversation

Simply007
Copy link
Contributor

@Simply007 Simply007 commented Oct 22, 2021

Motivation

Upgrade to be compatible with Gatsby v4

https://v4.gatsbyjs.com/docs/reference/release-notes/migrating-source-plugin-from-v3-to-v4/
https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v3-to-v4

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults
  • Add sample of DSD and SSR to the repo and deploy it to netlify Showcase Gatsby SSR and DSG  #196

How to test

CI is fine

@Simply007 Simply007 requested a review from makma October 22, 2021 12:07
@Simply007 Simply007 mentioned this pull request Oct 22, 2021
5 tasks
@Simply007
Copy link
Contributor Author

Version 8.0.0-beta.0 of packages:

@Simply007
Copy link
Contributor Author

makma
makma previously approved these changes Oct 29, 2021
Copy link
Contributor

@makma makma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my project, works like a charm. Thanks!

@bwlng
Copy link

bwlng commented Nov 15, 2021

@Simply007 Tested on our project and it works as expected when upgrading from version 7, but Deferred Static Generation does not work. Adding the defer argument to the createPage action results in the following error.

Gatsby kontent source plugin resulted to error in `createSchemaCustomization` method ENOENT: no such file or directory, open '.cache/query-engine/template.items.schema.gql'

  Error: ENOENT: no such file or directory, open '.cache/query-engine/template.items.schema.gql'

I have a simple reproduction in this repo with reproducible steps in the README.

Would you like me to open a separate issue?

@Simply007
Copy link
Contributor Author

@Simply007 Tested on our project and it works as expected when upgrading from version 7, but Deferred Static Generation does not work. Adding the defer argument to the createPage action results in the following error.

Gatsby kontent source plugin resulted to error in `createSchemaCustomization` method ENOENT: no such file or directory, open '.cache/query-engine/template.items.schema.gql'

  Error: ENOENT: no such file or directory, open '.cache/query-engine/template.items.schema.gql'

I have a simple reproduction in this repo with reproducible steps in the README.

Would you like me to open a separate issue?

Thanks for testing this out! I was planning to try it myself (#196). And yes please - submit a separate issue. It seems more like a gatsby issue - it might not cache .gql files out of the box (I am using them as a template for schema customization).

@Simply007
Copy link
Contributor Author

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Simply007
Copy link
Contributor Author

Hello everybody, We are planning to release a final version 8.0.0 in the middle of Feb 2022.

@Simply007
Copy link
Contributor Author

Simply007 commented Feb 8, 2022

It is here! 🚀 I am going to release this version as the latest tomorrow (most probably). It is already verified and being used without submitted issues. but one:

tl;dr; - if you want to use the kontent gatsby source plugin - ideally update to gatsby v 4.6.2 (4.6.1) does not work.

ping @CollierCZ @drewfoster-luminary (thx again for the issue fix) as the thumbs-uppers for the latest comment :)

@Simply007 Simply007 marked this pull request as ready for review February 8, 2022 07:08
@Simply007 Simply007 requested a review from a team February 8, 2022 07:08
@Simply007 Simply007 merged commit 3033eee into master Feb 10, 2022
@Simply007 Simply007 deleted the gatsbyv4-upgrade branch February 10, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants