Feat/renditions #227
Merged
Feat/renditions #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2022 22:23
|
based on #216 |
|
Ideally cover with more tests |
|
I don't have ideas for tests. I am good with infering the renditions, however I would like to have it covered with readme. |
|
I will link it from the source plugin showcase and extend the showcase for image resolution - with another example in the picture tag. |
IvanKiral
requested changes
Jan 4, 2023
|
|
||
|
|
||
|
|
||
| {avatar.renditions && |
There was a problem hiding this comment.
Suggestion: I would showcase this in readme as renditions might not be there and explain why (also renditions are not allowed in developer plan) or atleast add comment here to explain why they should not forget check if renditions are there. What do you think?
Co-authored-by: Ivan Kiráľ <[email protected]>
IvanKiral
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #215
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?