Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1782676: Do not hardcode GOARCH=amd64 #10

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Bug 1782676: Do not hardcode GOARCH=amd64 #10

merged 1 commit into from
Dec 12, 2019

Conversation

yselkowitz
Copy link

This is necessary for multi-arch support.

This is necessary for multi-arch support.
@openshift-ci-robot
Copy link

@yselkowitz: This pull request references Bugzilla bug 1782676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1782676: Do not hardcode GOARCH=amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 12, 2019
@openshift-ci-robot
Copy link

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2019
@yselkowitz
Copy link
Author

/cherry-pick release-4.3
/cherry-pick release-4.2

@openshift-cherrypick-robot

@yselkowitz: only operator-framework org members may request cherry-picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.3
/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 12, 2019
@timflannagan
Copy link

/cherry-pick release-4.3
/cherry-pick release-4.2

@openshift-cherrypick-robot

@timflannagan1: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3
/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timflannagan1, yselkowitz
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link

Oh, right I don't have approve privileges in this repo - force merging.

@timflannagan timflannagan merged commit cba3bc6 into kube-reporting:master Dec 12, 2019
@openshift-ci-robot
Copy link

@yselkowitz: All pull requests linked via external trackers have merged. Bugzilla bug 1782676 has been moved to the MODIFIED state.

In response to this:

Bug 1782676: Do not hardcode GOARCH=amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@timflannagan1: new pull request created: #11

In response to this:

/cherry-pick release-4.3
/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz added a commit to yselkowitz/ocp-build-data that referenced this pull request Dec 13, 2019
sosiouxme pushed a commit to openshift-eng/ocp-build-data that referenced this pull request Dec 13, 2019
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ocp-build-data that referenced this pull request Dec 13, 2019
sosiouxme pushed a commit to openshift-eng/ocp-build-data that referenced this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants