Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA: admin-controlled device attributes #5027

Open
1 of 4 tasks
pohly opened this issue Jan 8, 2025 · 11 comments
Open
1 of 4 tasks

DRA: admin-controlled device attributes #5027

pohly opened this issue Jan 8, 2025 · 11 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Milestone

Comments

@pohly
Copy link
Contributor

pohly commented Jan 8, 2025

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 8, 2025
@pohly
Copy link
Contributor Author

pohly commented Jan 8, 2025

/sig node
/sig scheduling
/wg device-management

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Jan 8, 2025
@eero-t
Copy link

eero-t commented Jan 13, 2025

By overriding device attributes, cluster admins can prevent usage of certain devices (unhealthy, taken offline for maintenance)

How admin should run test workload(s) on device which scheduling has been disabled (e.g. for firmware upgrade), to know whether it can be enabled egain (for production workloads)?

With node taints, one would use taint tolerance for this, but I don't seem from KEP description how similar thing would be achieved for DRA devices.

@pohly
Copy link
Contributor Author

pohly commented Jan 13, 2025

@eero-t: let's discuss in the PR, there we have threading => https://github.com/kubernetes/enhancements/pull/5034/files#r1913015929

@pohly pohly changed the title DRA: admin-controlled device attributes (device health, maintenance, priority) DRA: admin-controlled device attributes Jan 20, 2025
@pohly pohly moved this from 🆕 New to 🏗 In progress in SIG Node: Dynamic Resource Allocation Jan 21, 2025
@kannon92
Copy link
Contributor

Another one that needs an opt-in label to be tracked for enhancements.

@pohly
Copy link
Contributor Author

pohly commented Feb 3, 2025

/assign

@Huang-Wei
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 6, 2025
@dipesh-rawat dipesh-rawat added this to the v1.33 milestone Feb 6, 2025
@haircommander haircommander moved this to Proposed for consideration in SIG Node 1.33 KEPs planning Feb 6, 2025
@lzung
Copy link

lzung commented Feb 7, 2025

Hello @pohly 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 7, 2025
@lzung lzung moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 7, 2025
@dipesh-rawat
Copy link
Member

Hi @pohly 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #5027 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hello @pohly 👋, 1.33 Enhancements team here,

With PR #5034 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

Aside from the minor nits mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
(cc: @lzung)

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 12, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 12, 2025
@pohly
Copy link
Contributor Author

pohly commented Feb 13, 2025

Description updated.

@haircommander haircommander moved this from Proposed for consideration to Tracked in SIG Node 1.33 KEPs planning Feb 14, 2025
@sreeram-venkitesh
Copy link
Member

Hi @pohly! 👋 v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: Tracked for enhancements freeze
Status: Tracked
Status: 🏗 In progress
Status: Needs Triage
Development

No branches or pull requests

8 participants