Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Apply: Unsetting Fields #5051

Open
4 tasks
jpbetz opened this issue Jan 18, 2025 · 6 comments
Open
4 tasks

Server Side Apply: Unsetting Fields #5051

jpbetz opened this issue Jan 18, 2025 · 6 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Jan 18, 2025

Enhancement Description

-Server Side Apply: Unsetting Fields

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 18, 2025
@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 18, 2025

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 18, 2025
@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 18, 2025

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2025
@dipesh-rawat
Copy link
Member

Hello @jpbetz 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 28, 2025
@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Jan 28, 2025
@dipesh-rawat
Copy link
Member

Hi @jpbetz 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #5051 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 11, 2025

/remove-milestone

Per offline discussion. We'd like to drop this enhancement from 1.34. Introducing marker values results in data that is not schema compatible with embedded types. There is no obvious solution to this and it seems a safer path to drop this than introduce a primitive into server side apply that does not interact well with the rest of api machinery.

@dipesh-rawat
Copy link
Member

@jpbetz Thanks for the confirmation. Now planned that this will be planned for a future release. I will go ahead and mark it as Deferred on the v1.33 board for tracking purposes - do let the enhancement team know otherwise.

/remove-label lead-opted-in
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.33 milestone Feb 11, 2025
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 11, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Deferred in 1.33 Enhancements Tracking Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Deferred
Development

No branches or pull requests

3 participants