kep-4622: promote topologyMnagaer policy: max-allowable-numa-nodes to GA #5166
Conversation
cyclinder
commented
Feb 12, 2025
cyclinder
commented
- One-line PR description: topologyMnagaer policy: max-allowable-numa-nodes to GA(1.33)
- Issue link: KEP-4622: Add a TopologyManager policy option for MaxAllowableNUMANodes #4622
- Other comments:
- it was created in 1.31 as a beta feature: KEP-4622: New TopologyManager Policy: max-allowable-numa-nodes #4624
- The GA graduation would mean:
- the max-allowable-numa-nodes option will graduate to GA
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cyclinder The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
|
|
||
| <!-- | ||
| **Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone. | ||
| --> | ||
|
|
||
| [kubernetes.io]: https://kubernetes.io/ | ||
| [kubernetes/enhancements]: https://git.k8s.io/enhancements | ||
| [kubernetes/kubernetes]: https://git.k8s.io/kubernetes |
There was a problem hiding this comment.
vscode remove it😅, revert it now
| For GA: | ||
|
|
||
| - degrading the node and checking the node is reported as degraded | ||
|
|
There was a problem hiding this comment.
I kinda don't remember the context here, do we need this e2e to test it?
| @@ -249,7 +244,7 @@ For GA: | |||
|
|
|||
| #### GA | |||
|
|
|||
| - Add a metrics: `kubelet_topology_manager_admission_time`. | |||
| - Add a metric: `kubelet_topology_manager_admission_time`. | |||
There was a problem hiding this comment.
please add a note documenting we can use an existing metric
| - `TopologyManagerPolicyBetaOptions` | ||
| - `TopologyManagerPolicyOptions` | ||
| - `TopologyManagerPolicyOptions` - going to be locked to true once GA |
There was a problem hiding this comment.
no need to mention the locking, it's the standard process for each feature
|
|
||
| # The following PRR answers are required at alpha release | ||
| # List the feature gate name and the components for which it must be enabled | ||
| feature-gates: | ||
| - name: "TopologyManagerPolicyBetaOptions" | ||
| components: |
There was a problem hiding this comment.
I'm curious too, maybe vscode's markdown linter removed it, revert it now.
Signed-off-by: Cyclinder Kuo <[email protected]>
|
I am supportive of graduating features to GA but not sure if we will get PRR in time as this came in late. |
same. I'll still be helping here with the reviews and cleaning up the feature, but if we miss the deadline (as unfortunately seems likely) is not too bad: we can prepare and be ready for a early 1.34 merge. |
