Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary Pod Distribution Budget updates by using ResoureVersion #130322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kei01234kei
Copy link
Contributor

@kei01234kei kei01234kei commented Feb 20, 2025

What type of PR is this?

/kind cleaup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Prevent unnecessary Pod Distribution Budget updates by using ResoureVersion.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- pr discussion: https://github.com/kubernetes/kubernetes/pull/30277#issuecomment-238985569
- pr discussion: https://github.com/kubernetes/kubernetes/pull/30277#issuecomment-238988825

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kei01234kei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kei01234kei
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 20, 2025
@kei01234kei kei01234kei changed the title use resource version to ignore updating pdb Prevent unnecessary Pod Distribution Budget updates by using resource version checks. Feb 20, 2025
@kei01234kei kei01234kei changed the title Prevent unnecessary Pod Distribution Budget updates by using resource version checks. Prevent unnecessary Pod Distribution Budget updates by using ResoureVersion Feb 20, 2025
@mimowo
Copy link
Contributor

mimowo commented Feb 21, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2025
@mimowo
Copy link
Contributor

mimowo commented Feb 21, 2025

We have analogous optimization in other controllers, based on the search by the comment.

I would suggest to update the PR description saying this is "cleanup" rather than "feature". It could maybe be considered as a performance bugfix, but I doubt it would be noticeable.

@kei01234kei
Copy link
Contributor Author

kei01234kei commented Feb 22, 2025

Thank you for reviewing my PR.

I would suggest to update the PR description saying this is "cleanup" rather than "feature".

I think this PR could be categorized as either "cleanup" or "feature". However, I chose "feature" because I thought using resource version in PDB is a new feature in the context of PDB controller.
But I'll follow your suggestion that "cleanup" is better than "feature" since you are more familiar with Kubernetes than I am :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

3 participants