Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong assertion on tests #130359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix wrong assertion on tests #130359

wants to merge 1 commit into from
+174 −67

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Feb 22, 2025 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #130346

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2025
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: my-git9
Once this PR has been reviewed and has the lgtm label, please assign caesarxuchao, random-liu, sttts for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2025
@my-git9 my-git9 requested a review from aojea February 22, 2025 12:34
aojea
aojea reviewed Feb 22, 2025
View reviewed changes
staging/src/k8s.io/apimachinery/third_party/forked/golang/json/fields.go
Comment on lines +362 to +364
// - S maps to s and to U+017F 'ſ' Latin small letter long s
// - k maps to K and to U+212A 'K' Kelvin sign
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't do unrelated changes, there are other places where comments are modified too

aojea
aojea reviewed Feb 22, 2025
View reviewed changes
staging/src/k8s.io/code-generator/third_party/forked/golang/reflect/type.go
Comment on lines +1 to +3
// This package is copied from Go library reflect/type.go.
// The struct tag library provides no way to extract the list of struct tags, only
// a specific tag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change, please leave it as it was before

@aojea
Copy link
Member

aojea commented Feb 22, 2025

almost there, only three issues left

@aojea
Copy link
Member

aojea commented Feb 22, 2025 •
edited
Loading

@my-git9 there are still missing files

RROR: staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/internal/generic/controller_test.go:202:3: go-require: require must only be used in the goroutine running the test function (testifylint)
ERROR:          require.ErrorIs(t, stopReason, context.Canceled)
ERROR:          ^
ERROR: staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/internal/generic/controller_test.go:258:3: go-require: require must only be used in the goroutine running the test function (testifylint)
ERROR:          require.ErrorIs(t, stopReason, context.Canceled)
ERROR:          ^
ERROR: staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/internal/generic/controller_test.go:290:3: go-require: require must only be used in the goroutine running the test function (testifylint)
ERROR:          require.ErrorIs(t, stopReason, context.DeadlineExceeded)
ERROR:          ^
ERROR: staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/internal/generic/controller_test.go:338:3: go-require: require must only be used in the goroutine running the test function (testifylint)
ERROR:          require.ErrorIs(t, stopReason, context.Canceled)
ERROR:          ^
ERROR: staging/src/k8s.io/apiserver/pkg/admission/plugin/policy/internal/generic/controller_test.go:395:3: go-require: require must only be used in the goroutine running the test function (testifylint)
ERROR:          require.ErrorIs(t, stopReason, context.Canceled)
ERROR:          ^

please enable the linter in our golangci config so we run it in presubmits

diff --git a/hack/golangci.yaml b/hack/golangci.yaml
index ff24e6d6d18..ed5382dc0f1 100644
--- a/hack/golangci.yaml
+++ b/hack/golangci.yaml
@@ -277,5 +277,4 @@ linters-settings: # please keep this alphabetized
     enable-all: true
     disable:  # TODO: remove each disabled rule and fix it
       - float-compare
-      - go-require
       - require-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

Assignees
No one assigned
Labels
area/apiserver area/code-generation area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong assertion on tests
3 participants
@my-git9 @k8s-ci-robot @aojea