-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb cipher/tls version serving options #42337
Conversation
|
||
// MinTLSVersion optionally overrides the minimum TLS version supported. | ||
// If 0, the default is used. | ||
MinTLSVersion uint16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document the format
|
||
// CipherSuites optionally overrides the list of cipher suites for the server. | ||
// If empty, the default is used. | ||
CipherSuites []uint16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document the format
|
||
// CipherSuites optionally overrides the list of allowed cipher suites for the server. | ||
// Values are from tls package constants (https://golang.org/pkg/crypto/tls/#pkg-constants). | ||
CipherSuites []uint16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sttts
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 38741, 41301, 43645, 43779, 42337) |
Needed to allow servers to harden or relax default tls versions and ciphers