remove legacy insecure port options from genericapiserver #42835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: deads2k Needs approval from an approver in each of these OWNERS Files:
We suggest the following people: |
k8s-github-robot
added
approved
|
This change is |
deads2k
force-pushed
the
server-01-remove-insecure
branch
from
5b2c053 to
a4d2fc1
Compare
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
LGTM 👍 |
deads2k
added
the
lgtm
|
@k8s-bot kops aws e2e test this |
deads2k
removed
the
lgtm
deads2k
force-pushed
the
server-01-remove-insecure
branch
from
a4d2fc1 to
b25aa67
Compare
deads2k
added
the
lgtm
k8s-github-robot
added
the
needs-rebase
deads2k
force-pushed
the
server-01-remove-insecure
branch
from
b25aa67 to
cd29754
Compare
k8s-github-robot
removed
lgtm
|
waiting for #43383 to merge before re-tagging. |
deads2k
added
the
lgtm
|
Automatic merge from submit-queue (batch tested with PRs 42835, 42974) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insecure port has been a source of problems and it will prevent proper aggregation into a cluster, so the genericapiserver has no need for it. In addition, there's no reason for it to be in the main kube-apiserver flow either. This pull removes it from genericapiserver and removes it from the shared kube-apiserver code. It's still wired up in the command, but its no longer possible for someone to mess up and start using in mainline code.
@kubernetes/sig-api-machinery-misc @ncdc