Create controller to auto register TPRs with the aggregator #43141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
size/XXL
|
This change is |
10 tasks
ncdc
reviewed
Mar 21, 2017
| for _, version := range tpr.Versions { | ||
| c.queue.Add(schema.GroupVersion{Group: group, Version: version.Name}) | ||
| } | ||
| } |
ncdc
reviewed
Mar 21, 2017
|
|
||
| apiServiceName := groupVersion.Version + "." + groupVersion.Group | ||
|
|
||
| if !hasResources { |
There was a problem hiding this comment.
What about if the cache is slow to sync? You could have a new TPR enqueued but it's not in the lister yet?
There was a problem hiding this comment.
What about if the cache is slow to sync? You could have a new TPR enqueued but it's not in the lister yet?
The cache is always at least as current as the enqueue for the same type.
deads2k
force-pushed
the
tpr-04-register
branch
2 times, most recently
from
be40e46 to
5b8c035
Compare
deads2k
added
approved
|
lgtm via irc. vendor/BUILD strikes again, so approving |
deads2k
removed
the
lgtm
deads2k
force-pushed
the
tpr-04-register
branch
from
5b8c035 to
1ef204a
Compare
deads2k
added
the
lgtm
|
Recording my lgtm 😄 |
k8s-github-robot
added
the
needs-rebase
fejta
removed
the
needs-rebase
|
Automatic merge from submit-queue (batch tested with PRs 43429, 43416, 43312, 43141, 43421) |
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 27, 2017
Automatic merge from submit-queue (batch tested with PRs 43694, 41262, 42911) combine kube-apiserver and kube-aggregator This combines several pulls currently in progress and wires them together. The aggregator sits in front of the normal kube-apiserver and allows local fallthrough instead of proxying. @kubernetes/sig-api-machinery-misc @DirectXMan12 since you seem invested, your life will get easier @luxas FYI since you've started trying to wire something together. Dependent Pulls LGTM: - [x] #42801 - [x] #42886 - [x] #42900 - [x] #42732 - [x] #42672 - [x] #43141 - [x] #43076 - [x] #43149 - [x] #43226 - [x] #43144
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #42732 (already lgtmed)
Creates a simple controller to wire TPRs with the API Service autoregistration controller.
@kubernetes/sig-api-machinery-misc @ncdc