-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename metric reflector_xx_last_resource_version #54921
rename metric reflector_xx_last_resource_version #54921
Conversation
…source_version{name="xx"}
Hi @weiwei04. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @smarterclayton |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, weiwei04 Associated issue: 52121 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 54800, 53898, 54812, 54921, 53558). If you want to cherry-pick this change to another branch, please follow the instructions here. |
/cherrypick-candidate |
anyone can help to cherry pick this into 1.8, thanks:) |
sorry for the disturb created a cherry-pick #54993 |
Automatic merge from submit-queue. UPSTREAM: 54921: rename metric reflector_xx_last_resource_version Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1509341 xref kubernetes/kubernetes#54921
What this PR does / why we need it:
mv reflector name from metric name to metric label
before:
after
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #52121
Special notes for your reviewer:
None
Release note: