docker-env: improve detecting powershell if SSHed from linux #10722

hetong07 · 2021-03-04T21:11:37Z

Make the minikube correctly detect it is running in powershell. The actual fix is here and this PR is only to reflect it in minikube. Also fix a character bug in test.

Before PR:

PS > \minikube-windows-amd64.exe docker-env
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.99.101:2376"
export DOCKER_CERT_PATH="C:\Users\imwise\.minikube\certs"
export MINIKUBE_ACTIVE_DOCKERD="minikube"

# To point your shell to minikube's docker-daemon, run:
# eval $(minikube -p minikube docker-env)

After PR:

PS > .\minikube-windows-amd64.exe docker-env
$Env:DOCKER_TLS_VERIFY = "1"
$Env:DOCKER_HOST = "tcp://192.168.99.101:2376"
$Env:DOCKER_CERT_PATH = "C:\Users\imwise\.minikube\certs"
$Env:MINIKUBE_ACTIVE_DOCKERD = "minikube"
# To point your shell to minikube's docker-daemon, run:
# & minikube -p minikube docker-env | Invoke-Expression

k8s-ci-robot · 2021-03-04T21:11:45Z

Hi @hetong07. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2021-03-04T21:12:03Z

Can one of the admins verify this patch?

medyagh · 2021-03-04T21:24:10Z

/ok-to-test

medyagh

thanks @hetong07 please see comment, lets see if this passes the windows tests

cmd/minikube/cmd/docker-env.go

minikube-pr-bot · 2021-03-05T02:02:53Z

kvm2 Driver
Times for minikube: 92.8s 85.7s 86.1s
Average time for minikube: 88.2s

Times for Minikube (PR 10722): 71.9s 68.5s 71.8s
Average time for Minikube (PR 10722): 70.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.4s    | 43.8s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 19.3s    | 9.5s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 4.8s     | 2.8s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.8s    | 10.8s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.4s     | 1.1s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.6s     | 0.9s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 46.1s 44.9s 46.4s
Average time for minikube: 45.8s

Times for Minikube (PR 10722): 26.9s 34.1s 32.2s
Average time for Minikube (PR 10722): 31.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 1.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 11.2s    | 12.8s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 32.5s    | 15.7s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.6s     | 1.0s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

hetong07 · 2021-03-05T20:10:48Z

This change seems to be better happen in https://github.com/machine-drivers/machine, so create a PR there machine-drivers/machine#33

medyagh

now that this is fixed in libmachine, please update the go.mod replace section to use latest libmachine fork

machine-drivers/machine#33

hetong07 · 2021-03-07T04:32:48Z

@medyagh Updated via go get github.com/machine-drivers/machine.

minikube-pr-bot · 2021-03-07T04:50:55Z

kvm2 Driver
Times for minikube: 69.3s 70.1s 72.1s
Average time for minikube: 70.5s

Times for Minikube (PR 10722): 69.9s 69.9s 69.1s
Average time for Minikube (PR 10722): 69.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 43.7s    | 43.3s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.2s     | 2.2s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 4.2s     | 3.9s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.8s    | 16.0s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.6s     | 1.6s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.5s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.3s     | 0.8s                |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.1s 30.9s 28.0s
Average time for minikube: 29.0s

Times for Minikube (PR 10722): 31.1s 36.4s 31.1s
Average time for Minikube (PR 10722): 32.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 1.3s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 11.1s    | 14.1s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.1s    | 16.0s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.0s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

sharifelgamal · 2021-03-08T22:05:42Z

/ok-to-test

medyagh

The dockerEnv test still fails
https://storage.googleapis.com/minikube-builds/logs/10722/cb626a1/Docker_Windows.html#fail_TestFunctional%2fparallel%2fDockerEnv

-- /stdout --
** stderr ** 
	export : The term 'export' is not recognized as the name of a cmdlet, function, script file, or operable program. 
	Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
	At line:1 char:1
	+ export DOCKER_TLS_VERIFY="1"
	+ ~~~~~~
	    + CategoryInfo          : ObjectNotFound: (export:String) [], CommandNotFoundException
	    + FullyQualifiedErrorId : CommandNotFoundException

k8s-ci-robot · 2021-03-10T00:50:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hetong07
To complete the pull request process, please assign afbjorklund after the PR has been reviewed.
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

go.mod

hetong07 · 2021-03-10T18:35:01Z

@medyagh This is because the PR to machine-drivers has not be correctly reflected. Solving this by

go mod edit -replace github.com/docker/machine=github.com/machine-drivers/machine@master 
go mod download github.com/docker/machine (hinted by make)

minikube-pr-bot · 2021-03-10T19:01:29Z

kvm2 Driver
Times for minikube: 64.4s 63.7s 62.4s
Average time for minikube: 63.5s

Times for Minikube (PR 10722): 62.2s 61.2s 63.0s
Average time for Minikube (PR 10722): 62.2s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 36.7s    | 36.7s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.6s    | 2.1s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 1.5s     | 4.5s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 5.2s     | 15.1s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.9s     | 1.2s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.4s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.9s     | 1.2s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 26.3s 26.8s 26.3s
Average time for minikube: 26.5s

Times for Minikube (PR 10722): 27.8s 27.0s 26.7s
Average time for Minikube (PR 10722): 27.2s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 9.7s     | 9.6s                |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.1s    | 15.7s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

medyagh · 2021-03-10T21:50:45Z

@hetong07 this time we got passed initial error export : The term 'export' is not recognized as the name of a cmdlet but we got another error, do u mind trying it manually ? is the command given by minikube missing a Dot ?
https://storage.googleapis.com/minikube-builds/logs/10722/c7a4943/Docker_Windows.html#fail_TestFunctional%2fparallel%2fDockerEnv

** stderr ** 
	Invoke-Expression : At line:1 char:36
	+ REM To point your shell to minikube's docker-daemon, run:
	+                                    ~~~~~~~~~~~~~~~~~~~~~~
	The string is missing the terminator: '.
	At line:1 char:79
	+ ... functional-20210310191609-6496 docker-env | Invoke-Expression ; docke ...
	+                                                 ~~~~~~~~~~~~~~~~~
	    + CategoryInfo          : ParserError: (:) [Invoke-Expression], ParseException
	    + FullyQualifiedErrorId : TerminatorExpectedAtEndOfString,Microsoft.PowerShell.Commands.InvokeExpressionCommand
	 
** /stderr ***

minikube-pr-bot · 2021-03-10T23:31:50Z

kvm2 Driver
Times for minikube: 63.3s 64.7s 61.9s
Average time for minikube: 63.3s

Times for Minikube (PR 10722): 63.4s 64.9s 61.0s
Average time for Minikube (PR 10722): 63.1s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 38.2s    | 38.1s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 8.8s     | 1.9s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 2.6s     | 4.5s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 9.9s     | 14.7s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.1s     | 1.4s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.5s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.8s     | 1.4s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.6s 26.4s 28.0s
Average time for minikube: 27.4s

Times for Minikube (PR 10722): 28.5s 26.6s 27.6s
Average time for Minikube (PR 10722): 27.6s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 9.8s     | 9.9s                |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.9s    | 15.6s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

medyagh · 2021-03-13T03:23:00Z

/retest-this-please

medyagh · 2021-03-15T20:30:34Z

/retest-this-please

sharifelgamal · 2021-03-15T20:44:31Z

/ok-to-test

… charator.

minikube-pr-bot · 2021-03-23T05:11:31Z

kvm2 Driver
Times for minikube: 67.8s 68.4s 65.8s
Average time for minikube: 67.3s

Times for Minikube (PR 10722): 65.0s 65.7s 66.1s
Average time for Minikube (PR 10722): 65.6s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 39.9s    | 39.6s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.3s     | 8.8s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 5.1s     | 3.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 15.7s    | 10.1s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.6s     | 1.3s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.5s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 1.3s     |                     |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.8s 31.4s 31.3s
Average time for minikube: 30.2s

Times for Minikube (PR 10722): 32.0s 27.6s 34.9s
Average time for Minikube (PR 10722): 31.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10722) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.8s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 1.7s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 12.6s    | 11.0s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.9s    | 16.4s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2021

k8s-ci-robot requested review from blueelvis and ilya-zuyev March 4, 2021 21:11

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2021

medyagh requested changes Mar 4, 2021

View reviewed changes

cmd/minikube/cmd/docker-env.go Outdated Show resolved Hide resolved

kubernetes deleted a comment from minikube-pr-bot Mar 5, 2021

medyagh requested changes Mar 6, 2021

View reviewed changes

hetong07 force-pushed the deocker-env-windows branch from 5973cfc to cb626a1 Compare March 7, 2021 04:31

hetong07 requested a review from medyagh March 8, 2021 20:46

medyagh approved these changes Mar 10, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021

medyagh requested changes Mar 10, 2021

View reviewed changes

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021

medyagh requested changes Mar 10, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

hetong07 force-pushed the deocker-env-windows branch from cb626a1 to c7a4943 Compare March 10, 2021 18:32

hetong07 requested a review from medyagh March 10, 2021 18:37

medyagh changed the title ~~Windows-test: Correctly detect powershell when minikube is called on through SSH~~ windows: improve detecting powershell for docker-env (if SSHed from linux) Mar 15, 2021

medyagh changed the title ~~windows: improve detecting powershell for docker-env (if SSHed from linux)~~ docker-env: improve detecting powershell if SSHed from linux Mar 15, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2021

hetong07 and others added 3 commits March 22, 2021 21:51

update go.sum and go.mod to reflect machine-drivers/machine#33

5f0720e

Fix the bug in functional_test/docker-env, which is caused by a wrong…

858531c

… charator.

merge upstream

cc7973a

medyagh force-pushed the deocker-env-windows branch from a4c6908 to cc7973a Compare March 23, 2021 04:53

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2021

medyagh merged commit f29366a into kubernetes:master Mar 23, 2021

hetong07 deleted the deocker-env-windows branch March 31, 2021 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docker-env: improve detecting powershell if SSHed from linux #10722

docker-env: improve detecting powershell if SSHed from linux #10722

hetong07 commented Mar 4, 2021 •

edited

Loading

k8s-ci-robot commented Mar 4, 2021

minikube-bot commented Mar 4, 2021

medyagh commented Mar 4, 2021

medyagh left a comment •

edited

Loading

minikube-pr-bot commented Mar 5, 2021

hetong07 commented Mar 5, 2021

medyagh left a comment

hetong07 commented Mar 7, 2021

minikube-pr-bot commented Mar 7, 2021

sharifelgamal commented Mar 8, 2021

medyagh left a comment

k8s-ci-robot commented Mar 10, 2021

hetong07 commented Mar 10, 2021 •

edited

Loading

minikube-pr-bot commented Mar 10, 2021

medyagh commented Mar 10, 2021

minikube-pr-bot commented Mar 10, 2021

medyagh commented Mar 13, 2021

medyagh commented Mar 15, 2021

sharifelgamal commented Mar 15, 2021

minikube-pr-bot commented Mar 23, 2021

docker-env: improve detecting powershell if SSHed from linux #10722

docker-env: improve detecting powershell if SSHed from linux #10722

Conversation

hetong07 commented Mar 4, 2021 • edited Loading

k8s-ci-robot commented Mar 4, 2021

minikube-bot commented Mar 4, 2021

medyagh commented Mar 4, 2021

medyagh left a comment • edited Loading

Choose a reason for hiding this comment

minikube-pr-bot commented Mar 5, 2021

hetong07 commented Mar 5, 2021

medyagh left a comment

Choose a reason for hiding this comment

hetong07 commented Mar 7, 2021

minikube-pr-bot commented Mar 7, 2021

sharifelgamal commented Mar 8, 2021

medyagh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 10, 2021

hetong07 commented Mar 10, 2021 • edited Loading

minikube-pr-bot commented Mar 10, 2021

medyagh commented Mar 10, 2021

minikube-pr-bot commented Mar 10, 2021

medyagh commented Mar 13, 2021

medyagh commented Mar 15, 2021

sharifelgamal commented Mar 15, 2021

minikube-pr-bot commented Mar 23, 2021

hetong07 commented Mar 4, 2021 •

edited

Loading

medyagh left a comment •

edited

Loading

hetong07 commented Mar 10, 2021 •

edited

Loading