-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ipv4 cidr in cilium #12587
Fix Ipv4 cidr in cilium #12587
Conversation
Welcome @duttaANI! |
Hi @duttaANI. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
951d077
to
cd89ccd
Compare
/ok-to-test |
pkg/minikube/cni/cilium.go
Outdated
@@ -175,7 +175,7 @@ data: | |||
hubble-tls-key-file: /var/lib/cilium/tls/hubble/server.key | |||
hubble-tls-client-ca-files: /var/lib/cilium/tls/hubble/client-ca.crt | |||
ipam: "cluster-pool" | |||
cluster-pool-ipv4-cidr: "10.0.0.0/8" | |||
cluster-pool-ipv4-cidr: "10.244.0.0/16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing this
we should make "tempaltized" for example
"{{ .PodSubnet }}"
so if user passes extra args we should use that simmilar to here
podSubnet: "{{.PodSubnet }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the template for extra args .
kvm2 driver with docker runtime
Times for minikube start: 49.3s 48.9s 48.2s 49.1s 48.8s Times for minikube ingress: 32.8s 32.8s 34.2s 31.8s 32.3s docker driver with docker runtime
Times for minikube ingress: 26.9s 35.4s 27.9s 27.9s 35.4s Times for minikube start: 22.5s 21.2s 20.9s 22.9s 22.6s docker driver with containerd runtime
Times for minikube ingress: 38.4s 31.9s 27.4s 29.4s 36.9s Times for minikube start: 27.4s 42.3s 44.2s 43.7s 43.4s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
/assign @medyagh |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 49.0s 47.6s 48.2s 46.5s 47.1s Times for minikube ingress: 32.3s 31.3s 31.2s 29.3s 30.8s docker driver with docker runtime
Times for minikube start: 22.2s 21.1s 23.0s 21.1s 22.4s Times for minikube ingress: 27.5s 27.0s 27.0s 28.0s 26.4s docker driver with containerd runtime
Times for minikube start: 31.2s 41.8s 43.3s 43.2s 43.9s Times for minikube ingress: 29.5s 32.9s 28.5s 32.9s 32.9s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Thank you for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duttaANI, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
fixes #12077
issue link : issue